Skip to content

fix(utils/url): specify the return type of tryDecodeURI#4779

Merged
yusukebe merged 1 commit intomainfrom
fix/util-url-try-decode-uri-return-type
Mar 3, 2026
Merged

fix(utils/url): specify the return type of tryDecodeURI#4779
yusukebe merged 1 commit intomainfrom
fix/util-url-try-decode-uri-return-type

Conversation

@yusukebe
Copy link
Copy Markdown
Member

@yusukebe yusukebe commented Mar 3, 2026 •
edited
Loading

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

Bundle size check

main (6a0607a) #4779 (7302fb2) +/-
Bundle Size (B) 18,483B 18,483B 0B
Bundle Size (KB) 18.05K 18.05K 0K

Compiler Diagnostics (tsc)

main (6a0607a) #4779 (7302fb2) +/-
Files 303 303 0
Lines 141,265 141,265 0
Identifiers 129,292 129,293 1
Symbols 269,217 269,217 0
Types 198,801 198,801 0
Instantiations 614,196 614,196 0
Memory used 332,933K 338,919K 5,986K
I/O read 0.03s 0.03s 0s
I/O write 0s 0s 0s
Parse time 0.83s 0.72s -0.11s
Bind time 0.36s 0.34s -0.02s
Check time 2.84s 2.83s -0.01s
Emit time 0s 0s 0s
Total time 4.03s 3.9s -0.13s

Compiler Diagnostics (typescript-go)

main (6a0607a) #4779 (7302fb2) +/-
Files 303 303 0
Lines 145,446 145,446 0
Identifiers 130,883 130,884 1
Symbols 390,110 387,297 -2,813
Types 366,094 366,094 0
Instantiations 988,653 988,653 0
Memory used 252,108K 251,722K -386K
Memory allocs 2,557,888 2,557,892 4
Config time 0.001s 0.001s 0s
Parse time 0.11s 0.117s 0.007s
Bind time 0.021s 0.022s 0.001s
Check time 0.745s 0.613s -0.132s
Emit time 0s 0s 0s
Total time 0.94s 0.831s -0.109s

Reported by octocov

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 34,700.61 47,311.97 31,439.20 25,350.66
hono (current) bun 34,980.59 48,439.75 31,420.90 25,081.11
Change +0.81% +2.38% -0.06% -1.06%

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.47%. Comparing base (6a0607a) to head (5e6d417).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4779   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         177      177           
  Lines       11551    11551           
  Branches     3353     3354    +1     
=======================================
  Hits        10566    10566           
  Misses        984      984           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe merged commit 80a9837 into main Mar 3, 2026
20 checks passed
@yusukebe yusukebe deleted the fix/util-url-try-decode-uri-return-type branch March 3, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yusukebe