fix(jwt): validate token format in decode and decodeHeader functions#4752
Merged
yusukebe merged 2 commits intohonojs:mainfrom Mar 4, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4752 +/- ##
==========================================
- Coverage 91.48% 91.45% -0.03%
==========================================
Files 177 177
Lines 11556 11569 +13
Branches 3357 3363 +6
==========================================
+ Hits 10572 10581 +9
- Misses 983 987 +4
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hey @otoneko1102 I refactored the code to simplify nesting by myself. Looks good. I'll merge this now. Thank you for your contribution! |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the codedecode()anddecodeHeader()do not validate that the token has exactly 3 parts (header.payload.signature), whileverify()does. This inconsistency allows malformed tokens to be silently accepted bydecode().decode()anddecodeHeader(), consistent withverify()JwtTokenInvalidinstead of catching and wrapping it