perf(pattern-router): improve performance when create null object (#3730)

EdamAme-x · web-flow · commit 979510f70bb4 · 2024-12-09T11:26:35.000+09:00
diff --git a/src/router/pattern-router/router.ts b/src/router/pattern-router/router.ts
@@ -3,6 +3,8 @@ import { METHOD_NAME_ALL, UnsupportedPathError } from '../../router'
 
 type Route<T> = [RegExp, string, T] // [pattern, method, handler, path]
 
+const emptyParams = Object.create(null)
+
 export class PatternRouter<T> implements Router<T> {
   name: string = 'PatternRouter'
   #routes: Route<T>[] = []
@@ -46,7 +48,7 @@ export class PatternRouter<T> implements Router<T> {
       if (routeMethod === method || routeMethod === METHOD_NAME_ALL) {
         const match = pattern.exec(path)
         if (match) {
-          handlers.push([handler, match.groups || Object.create(null)])
+          handlers.push([handler, match.groups || emptyParams])
         }
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,8 @@ import { METHOD_NAME_ALL, UnsupportedPathError } from '../../router'`
`3`	`3`
`4`	`4`	`type Route<T> = [RegExp, string, T] // [pattern, method, handler, path]`
`5`	`5`
	`6`	`+const emptyParams = Object.create(null)`
	`7`	`+`
`6`	`8`	`export class PatternRouter<T> implements Router<T> {`
`7`	`9`	`name: string = 'PatternRouter'`
`8`	`10`	`#routes: Route<T>[] = []`
`@@ -46,7 +48,7 @@ export class PatternRouter<T> implements Router<T> {`
`46`	`48`	`if (routeMethod === method \|\| routeMethod === METHOD_NAME_ALL) {`
`47`	`49`	`const match = pattern.exec(path)`
`48`	`50`	`if (match) {`
`49`		`- handlers.push([handler, match.groups \|\| Object.create(null)])`
	`51`	`+ handlers.push([handler, match.groups \|\| emptyParams])`
`50`	`52`	`}`
`51`	`53`	`}`
`52`	`54`	`}`