Skip to content

Commit 93fc250

Browse files
authored
Merge commit from fork
* fix(cors): use `split` for Access-Control-Request-Headers * added a test
1 parent 51db313 commit 93fc250

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

‎src/middleware/cors/index.test.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,13 @@ describe('CORS by Middleware', () => {
158158
])
159159
})
160160

161+
it('Preflight handles a large Access-Control-Request-Headers value', async () => {
162+
const req = new Request('https://localhost/api/abc', { method: 'OPTIONS' })
163+
req.headers.append('Access-Control-Request-Headers', 'x' + ' '.repeat(200000) + 'x')
164+
const res = await app.request(req)
165+
expect(res.status).toBe(204)
166+
})
167+
161168
it('Preflight with options', async () => {
162169
const req = new Request('https://localhost/api2/abc', {
163170
method: 'OPTIONS',

‎src/middleware/cors/index.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ export const cors = (options?: CORSOptions): MiddlewareHandler => {
129129
if (!headers?.length) {
130130
const requestHeaders = c.req.header('Access-Control-Request-Headers')
131131
if (requestHeaders) {
132-
headers = requestHeaders.split(/\s*,\s*/)
132+
headers = requestHeaders.split(',').map((h) => h.trim())
133133
}
134134
}
135135
if (headers?.length) {

0 commit comments

Comments
 (0)