Repository navigation
Commit 8f07028
fix(compress): set Vary: Accept-Encoding on negotiated responses (#5137)
* fix(compress): set Vary: Accept-Encoding on compressed responses
The compress middleware negotiates gzip/deflate from the request's
Accept-Encoding header but never advertises Vary: Accept-Encoding on the
response. A shared cache can then store the compressed body and serve it
to a client that did not send a compatible Accept-Encoding, breaking that
client. Add Accept-Encoding to the response's Vary header when compressing,
appending to any existing Vary value and avoiding duplicates.
* fix(compress): set Vary: Accept-Encoding on identity responses too
Move the Vary handling ahead of the encoding negotiation so that a response
left uncompressed — because Accept-Encoding was absent or offered nothing the
middleware supports — is also marked as varying on Accept-Encoding. RFC 9110
lists Accept-Encoding "or lack thereof" as a determining factor, so without
this a shared cache can reuse the identity response for a client that does
accept gzip.
The helper now takes the Context and writes through ctx.header(), which
recreates the response when a handler returned a fetch() response. On Node
that recreation inherits the immutable header guard from the original
response, so the write can still throw; fall back to rebuilding the response
around a fresh Headers instance in that case.
* refactored
* remove the node.js test
* ci: apply automated fixes
---------
Co-authored-by: Yusuke Wada <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>1 parent 8a0b18f commit 8f07028
2 files changed
Lines changed: 101 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
259 | 259 | | |
260 | 260 | | |
261 | 261 | | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
262 | 349 | | |
263 | 350 | | |
264 | 351 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| 46 | + | |
| 47 | + | |
46 | 48 | | |
47 | 49 | | |
48 | 50 | | |
| |||
101 | 103 | | |
102 | 104 | | |
103 | 105 | | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
104 | 118 | | |
105 | 119 | | |
106 | 120 | | |
| |||
0 commit comments