Repository navigation
Commit 50b8788
authored
fix(client): keep a param value of "index" in $url() and $path() (#5297)
removeIndexString() strips a trailing /index so that the synthetic .index
accessor resolves to the route it aliases. In the $url()/$path() branch it ran
after the params had been substituted, so anything that merely looked like the
alias once substitution was done got stripped as well:
client.docs[':page'].$path({ param: { page: 'index' } }) // "/docs"
client.index[':v?'].$path({ param: { v: undefined } }) // "/"
The second is a route with a literal /index segment; "/" does not match it and
returns 404, so that URL never pointed at the route it came from.
The alias belongs to the route template and neither of those does, so the strip
now runs before substitution. ClientRequestImpl.fetch already does it in that
order, which is why $get() has always returned the right path for these routes
while $url() and $path() did not.1 parent 06880c4 commit 50b8788
2 files changed
Lines changed: 75 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1243 | 1243 | | |
1244 | 1244 | | |
1245 | 1245 | | |
| 1246 | + | |
| 1247 | + | |
| 1248 | + | |
| 1249 | + | |
1246 | 1250 | | |
1247 | 1251 | | |
1248 | 1252 | | |
| |||
1270 | 1274 | | |
1271 | 1275 | | |
1272 | 1276 | | |
| 1277 | + | |
| 1278 | + | |
| 1279 | + | |
| 1280 | + | |
| 1281 | + | |
| 1282 | + | |
| 1283 | + | |
| 1284 | + | |
| 1285 | + | |
| 1286 | + | |
| 1287 | + | |
| 1288 | + | |
| 1289 | + | |
| 1290 | + | |
| 1291 | + | |
| 1292 | + | |
| 1293 | + | |
| 1294 | + | |
| 1295 | + | |
| 1296 | + | |
| 1297 | + | |
| 1298 | + | |
| 1299 | + | |
| 1300 | + | |
| 1301 | + | |
| 1302 | + | |
| 1303 | + | |
| 1304 | + | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
| 1308 | + | |
| 1309 | + | |
| 1310 | + | |
| 1311 | + | |
| 1312 | + | |
1273 | 1313 | | |
1274 | 1314 | | |
1275 | 1315 | | |
1276 | | - | |
1277 | | - | |
1278 | | - | |
1279 | | - | |
1280 | | - | |
1281 | | - | |
1282 | | - | |
| 1316 | + | |
| 1317 | + | |
| 1318 | + | |
| 1319 | + | |
| 1320 | + | |
| 1321 | + | |
| 1322 | + | |
| 1323 | + | |
| 1324 | + | |
1283 | 1325 | | |
1284 | 1326 | | |
1285 | 1327 | | |
| |||
1298 | 1340 | | |
1299 | 1341 | | |
1300 | 1342 | | |
| 1343 | + | |
| 1344 | + | |
| 1345 | + | |
| 1346 | + | |
| 1347 | + | |
| 1348 | + | |
| 1349 | + | |
| 1350 | + | |
| 1351 | + | |
| 1352 | + | |
| 1353 | + | |
| 1354 | + | |
| 1355 | + | |
| 1356 | + | |
| 1357 | + | |
| 1358 | + | |
| 1359 | + | |
| 1360 | + | |
| 1361 | + | |
| 1362 | + | |
| 1363 | + | |
| 1364 | + | |
1301 | 1365 | | |
1302 | 1366 | | |
1303 | 1367 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
190 | | - | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
191 | 193 | | |
192 | 194 | | |
193 | | - | |
| 195 | + | |
194 | 196 | | |
195 | 197 | | |
196 | 198 | | |
197 | 199 | | |
198 | 200 | | |
199 | | - | |
200 | 201 | | |
201 | 202 | | |
202 | 203 | | |
| |||
0 commit comments