Skip to content

fix: use pnpm for npm publish in release workflow#480

Merged
azu merged 1 commit intomasterfrom
fix/use-pnpm-for-release-publish
Sep 8, 2025
Merged

fix: use pnpm for npm publish in release workflow#480
azu merged 1 commit intomasterfrom
fix/use-pnpm-for-release-publish

Conversation

@azu
Copy link
Copy Markdown
Member

@azu azu commented Sep 8, 2025

Summary

This PR fixes the package publishing step in the release workflow by switching from npm to pnpm for consistency and proper workspace handling.

Problem

The release workflow was using npm -r publish instead of pnpm -r publish, which caused several issues:

  • Inconsistent package manager usage: The workflow uses pnpm everywhere else (installation, dependency management) but was using npm for publishing
  • Private package handling: The root package honkit-root is marked as "private": true in package.json, but npm's recursive publish doesn't properly respect workspace configurations
  • Missing git checks flag: The pnpm publish command needs --no-git-checks flag in CI environments

Solution

Changed the publish command from:

npm -r publish --access public

To:

pnpm -r publish --access public --no-git-checks

This ensures:

  • Consistent use of pnpm throughout the entire workflow
  • Proper handling of private packages in the monorepo workspace
  • Successful publishing in CI environment with the --no-git-checks flag

Test Plan

N/A - This change affects the automated release workflow which runs when a Release PR is merged. The change will be validated when the next release is published.

🤖 Generated with Claude Code

- Switch from npm to pnpm for consistent package manager usage
- Add --no-git-checks flag for CI environment
- Properly handle private packages in workspace

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@azu azu added the Type: CI Changes to CI configuration files and scripts label Sep 8, 2025
@azu azu marked this pull request as ready for review September 8, 2025 13:34
@azu azu merged commit 912e57f into master Sep 8, 2025
18 of 19 checks passed
@azu azu deleted the fix/use-pnpm-for-release-publish branch September 8, 2025 13:34
This was referenced Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: CI Changes to CI configuration files and scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant