Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a callable check for the exception handler #97

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Added a callable check for the exception handler #97

merged 1 commit into from
Nov 18, 2019

Conversation

sixlive
Copy link
Collaborator

@sixlive sixlive commented Nov 11, 2019

Description

Added a check to make sure the previous global exception handler is callable before we call it.

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

@sixlive sixlive requested a review from stympy November 11, 2019 23:15
@sixlive sixlive self-assigned this Nov 11, 2019
stympy
stympy approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@stympy stympy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stympy
Copy link
Member

stympy commented Nov 18, 2019

@sixlive bump :)

@sixlive
Copy link
Collaborator Author

sixlive commented Nov 18, 2019

Thanks for the bump! @stympy

@sixlive sixlive merged commit fa53f3a into honeybadger-io:master Nov 18, 2019
@sixlive sixlive deleted the fix-exception-handler branch November 18, 2019 20:48
@stympy
Copy link
Member

stympy commented Nov 18, 2019

@sixlive Sure thing. :) Are you planning to make a new release?

stympy added a commit that referenced this pull request Nov 22, 2019
@stympy
Backport changes from #97
f0820ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stympy stympy stympy approved these changes

Assignees

@sixlive sixlive

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sixlive @stympy