Use JSON_PARTIAL_OUTPUT_ON_ERROR when encoding JSON payload
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This proposes a fix for #93, where a recursive payload made the notification to fail because `json_encode` returns `null` in that case.
joshuap
reviewed
Oct 21, 2019
CHANGELOG.md
Outdated
| @@ -5,6 +5,10 @@ adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ## [2.0.1] - 2019-09-21 | |||
There was a problem hiding this comment.
Can you remove this heading and the blank line above it, keeping the "Unreleased" heading? We'll add in the appropriate heading at the time of release. Thanks!
There was a problem hiding this comment.
Ah, I see, now I get it :-). Yes, sure!
I also wrote "Fixed" instead of "Changed" now, since this is more of a fix instead of a change in functionality.
sixlive
approved these changes
Nov 11, 2019
sixlive
pushed a commit
to sixlive/honeybadger-php
that referenced
this pull request
Nov 22, 2019
sixlive
added a commit
that referenced
this pull request
Dec 4, 2019
Use `JSON_PARTIAL_OUTPUT_ON_ERROR` when encoding JSON payload (#96)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes a fix for #93,
where a recursive payload made the notification to fail because
json_encodereturns
nullin that case.Status
READY (imho)
Description
As stated in #93 , we have a problem with some exceptions that contain recursive references in their trance. Those cannot be
json_encodedsuccessfully, sojson_encodesilently returnsnull. Thus this exception won't be reported to the honeybadger backend.Todos
(I don't know
Steps to Test or Reproduce
I provided a test case in
tests/HoneybadgerClientTest.phpthat covers that behaviour. Running that test without the fix fails.