Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method arguments to backtrace #86

Merged
merged 3 commits into from
Jul 18, 2019
Merged

Add method arguments to backtrace #86

merged 3 commits into from
Jul 18, 2019

Conversation

sixlive
Copy link
Collaborator

@sixlive sixlive commented Jul 15, 2019 •
edited
Loading

Description

Adds method arguments to backtrace where available. Resolves #84

The following code creates the following report in HB.

<?php

function foo($foo, $bar)
{
    throw new \Exception('Test argument exception');
}

Route::get('/', function () {
    foo('asdfasdf', 'th293475239748at');
});

Screen Shot 2019-07-15 at 6 51 26 AM

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit

@sixlive sixlive self-assigned this Jul 15, 2019
@sixlive sixlive requested a review from joshuap July 15, 2019 11:01
@sixlive sixlive marked this pull request as ready for review July 15, 2019 11:01
stympy
stympy approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@stympy stympy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joshuap
joshuap approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@joshuap joshuap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@sixlive sixlive merged commit ff59b60 into honeybadger-io:master Jul 18, 2019
@sixlive sixlive deleted the add-method-arguments-to-backtrace branch July 18, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stympy stympy stympy approved these changes

@joshuap joshuap joshuap approved these changes

Assignees

@sixlive sixlive

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method call arguments on the stacktrace/backtrace
3 participants
@sixlive @stympy @joshuap