Update error handler with additional checks #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixlive
force-pushed
the
update-error-handler-with-additional-checks
branch
from
9be29bc to
d43b0f5
Compare
sixlive
force-pushed
the
update-error-handler-with-additional-checks
branch
from
1212740 to
6a023d9
Compare
|
Is the right way to return false or simply not to report it to honeybadger and still call previous error handler...? |
|
Honestly, I went back and forth on this several times. Almost all examples that I've reviewed just exited early if it shouldn't be reported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a check to ensure error reporting is enabled for that particular error. Fixes an issue where error suppression does not prevent the error from being reported.
Related Issues
Tasks