Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add class to notification #72

Merged
merged 8 commits into from
Aug 14, 2019
Merged

Add class to notification #72

merged 8 commits into from
Aug 14, 2019

Conversation

sixlive
Copy link
Collaborator

@sixlive sixlive commented Feb 11, 2019 •
edited
Loading

Description

Adds class to notification per Schema in #61.

Resolves #61.

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit

@sixlive sixlive self-assigned this Feb 11, 2019
@sixlive sixlive mentioned this pull request Feb 11, 2019
Closed
@sixlive sixlive force-pushed the feature-add-class-to-notice branch from 4b660e3 to 4f8f7dc Compare August 13, 2019 21:15
@sixlive
Copy link
Collaborator Author

sixlive commented Aug 13, 2019 •
edited
Loading

@joshuap I'm assuming this was added to the UI and I'm good to do some final integration testing?

@sixlive
Copy link
Collaborator Author

sixlive commented Aug 13, 2019

@joshuap I'm also sending the type if its defined.

@joshuap
Copy link
Member

joshuap commented Aug 13, 2019

@sixlive we don't have it added to the UI yet--I asked a few question on the issue here: #61

@joshuap
Copy link
Member

joshuap commented Aug 13, 2019

That said, as long as the correct values are being sent and it matches the schema changes we discussed, then ship it. We'll get to the UI after.

@sixlive sixlive changed the title [WIP] Add class to notification Add class to notification Aug 14, 2019
@sixlive sixlive merged commit 34e1fe7 into honeybadger-io:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sixlive sixlive

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send the class in addition to the function for each frame
2 participants
@sixlive @joshuap