Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the ability to reset context #71

Merged
merged 2 commits into from
Feb 11, 2019
Merged

Adds the ability to reset context #71

merged 2 commits into from
Feb 11, 2019

Conversation

sixlive
Copy link
Collaborator

@sixlive sixlive commented Feb 11, 2019

Status

READY

Description

Adds the ability to reset context.

$honebadger->resetContext();

Resolves #63

Related PRs

n/a

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit

@sixlive sixlive self-assigned this Feb 11, 2019
@sixlive sixlive requested a review from joshuap February 11, 2019 10:50
joshuap
joshuap approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@joshuap joshuap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One question--is context in general currently thread safe? If not, that's probably something I'd like to address in the future.

@sixlive
Copy link
Collaborator Author

sixlive commented Feb 11, 2019

@joshuap I'll look into it

@sixlive sixlive merged commit ee40a34 into honeybadger-io:master Feb 11, 2019
@sixlive sixlive deleted the feature-reset-context branch February 11, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuap joshuap joshuap approved these changes

Assignees

@sixlive sixlive

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sixlive @joshuap