Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monolog handler #70

Merged
merged 4 commits into from
Feb 11, 2019
Merged

Add monolog handler #70

merged 4 commits into from
Feb 11, 2019

Conversation

sixlive
Copy link
Collaborator

@sixlive sixlive commented Jan 20, 2019 •
edited
Loading

Status

WIP

Description

Adds a custom Monolog log handler that will send a custom formatted notification to Honeybadger. The custom payload content can be referenced in tests/LogHandlerTest.php#it_will_format_a_log_for_honeybadger test.

Resolves #13

Screenshot of log entry in HB

46895057-c13e8c80-ce44-11e8-9135-7af31f2716c5

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit

@sixlive sixlive self-assigned this Jan 20, 2019
@sixlive sixlive requested a review from joshuap January 20, 2019 15:19
This was referenced Jan 20, 2019
Closed
Merged
joshuap
joshuap approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@joshuap joshuap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

@sixlive sixlive added this to the v1.4.0 milestone Jan 27, 2019
@sixlive sixlive changed the title [WIP] Add monolog handler Add monolog handler Feb 11, 2019
@sixlive sixlive merged commit 804d9a4 into honeybadger-io:master Feb 11, 2019
@sixlive sixlive deleted the add-monolog-handler branch February 11, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuap joshuap joshuap approved these changes

Assignees

@sixlive sixlive

Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sixlive @joshuap