Lower required version of symfony/http-foundation #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixlive
changed the title
sixlive
changed the title
2 tasks
sixlive
force-pushed
the
lower-httpfoundation-version
branch
from
c59ce40 to
a40a72a
Compare
sixlive
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Lowers the required version constraints for
symfony/http-foundationsohoneybadger-laravelcan be compatible with Laravel 5.5 LTS.This incompatibility issue was actually identified while working on a new Travis configuration for
honeybadger-laravelto test against various version of Laravel.Before this change
After this change
I added a manual override to the repository to point to my repo and the branch for this PR.
Related PRs
Todos
Steps to Test or Reproduce
I actually bootstrapped a wild setup locally with satis,
honeybadger-laraveland Laravel 5.5, to test the install process. See the description section for some CI verification as well.