Log Handler: Ignore non-error logs #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalvah
commented
Aug 2, 2023
subzero10
approved these changes
Aug 3, 2023
| @@ -32,6 +32,10 @@ public function __construct(Reporter $honeybadger, int $level = Logger::DEBUG, b | |||
| */ | |||
| protected function write($record): void | |||
| { | |||
| if (!$this->isHandling($record)) { | |||
There was a problem hiding this comment.
Oh nice, this is already built-in so you just had to call it 👌
|
@shalvah I added a changelog entry to trigger the CI tests (I enabled them). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for honeybadger-io/honeybadger-laravel#105
It turns out that setting the minimum log level isn't enough; the handler has to explicitly check that the record passes.
Related: