Filter query string in env variables #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thought, this is a CGI thing, not necessarily a PHP thing. Ruby's CGI also includes I think we'll switch to that approach instead. The query string is already reported in the URL; there's no need for the duplication and extra variables. As an added bonus, we can cut down on the noise in the error report. |
shalvah
force-pushed
the
filter-query-string-in-env
branch
from
ec2a085 to
c1265c0
Compare
|
Updated. Diff's a bit hard to see because I rearranged the keys alphabetically, but the main change is removing the QUERY_STRING and REQUEST_URI from the whitelist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP includes the query string in QUERY_STRING and REQUEST_URI env vars, so we have to make sure to filter in those too. Fix for #153