Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint config option (Closes #139) #150

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Add endpoint config option (Closes #139) #150

merged 4 commits into from
Jun 16, 2021

Conversation

shalvah
Copy link
Contributor

@shalvah shalvah commented Jun 14, 2021

Status

READY

@shalvah
Copy link
Contributor Author

shalvah commented Jun 14, 2021

Note: the default endpoint includes the versioned path (https://api.honeybadger.io/v1/). That way, you can have <custom-endpoint>/notices and /checkins instead of being forced to use the same pathv1` in your custom endpoint.

@shalvah
Copy link
Contributor Author

shalvah commented Jun 14, 2021

Docs PR: #150

@shalvah shalvah requested a review from joshuap June 14, 2021 16:39
Copy link
Member

@joshuap joshuap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the default endpoint includes the versioned path (https://api.honeybadger.io/v1/). That way, you can have <custom-endpoint>/notices and /checkins instead of being forced to use the same pathv1` in your custom endpoint.

I like this in theory, but in all of our other clients, endpoint is assumed to be an instance of Honeybadger (i.e. an on-prem install), and the version info is included in the pathname after the user has provided the endpoint. Let's do that here to be consistent.

So if I configure "https://api.example.com", then it should send errors to "https://api.example.com/v1/notices"

@shalvah
Copy link
Contributor Author

shalvah commented Jun 16, 2021

Alright.

@shalvah shalvah merged commit 3ba3b9f into master Jun 16, 2021
@shalvah shalvah deleted the custom-endpoint branch June 16, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants