Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON-encode empty arrays properly #138

Merged
merged 3 commits into from
Mar 4, 2021
Merged

JSON-encode empty arrays properly #138

merged 3 commits into from
Mar 4, 2021

Conversation

shalvah
Copy link
Contributor

@shalvah shalvah commented Feb 26, 2021

Status

READY

Description

See #137 — /PHP's multitasking arrays (they're lists, maps, and everything in between) strike again! Fixed by setting the key to an object rather than array when empty.

@shalvah shalvah mentioned this pull request Feb 26, 2021
Closed
@joshuap joshuap requested a review from sixlive March 1, 2021 18:02
joshuap
joshuap approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@joshuap joshuap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@shalvah shalvah merged commit fa4b572 into master Mar 4, 2021
@shalvah shalvah deleted the encode-empty-maps-correctly branch March 4, 2021 20:12
@shalvah
Copy link
Contributor Author

shalvah commented Mar 4, 2021

Tested and verified ✅
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuap joshuap joshuap approved these changes

@sixlive sixlive Awaiting requested review from sixlive

Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shalvah @joshuap