Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly match vendor_paths on Windows #128

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Conversation

shalvah
Copy link
Contributor

@shalvah shalvah commented Feb 16, 2021

On Windows, file paths use backslashes (\) as opposed to Unix forward slashes (/). This makes matching of vendor_paths to not work correctly.

@joshuap joshuap requested a review from sixlive February 16, 2021 18:30
@shalvah
Copy link
Contributor Author

shalvah commented Feb 16, 2021

Also fixed the GH actions workflow — turns out it hasn't been running for a while.

@sixlive
Copy link
Collaborator

sixlive commented Feb 17, 2021

@shalvah I think there was some weirdness at one point with push AND pull_request where it was running double jobs, not sure why I ended up doing just push but ¯_(ツ)_/¯ lets do it!

@shalvah
Copy link
Contributor Author

shalvah commented Feb 17, 2021

Yeah @sixlive, I can see why that could happen. We could limit it to just PRs, if that's better.

@shalvah
Copy link
Contributor Author

shalvah commented Feb 17, 2021

@shalvah I think there was some weirdness at one point with push AND pull_request where it was running double jobs, not sure why I ended up doing just push but ¯_(ツ)_/¯ lets do it!

Also, the real problem wasn't in the config 😂. On the "Actions" tab, the workflow was marked as "disabled" because it had;t been used for several weeks. Just had to click Enable.

@shalvah shalvah merged commit 3e1742a into master Feb 17, 2021
@shalvah shalvah deleted the cross-platform-vendor-paths branch February 17, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants