Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add null check and default value for verify option #126

Merged
merged 1 commit into from
Feb 16, 2021
Merged

add null check and default value for verify option #126

merged 1 commit into from
Feb 16, 2021

Conversation

johanrosenson
Copy link
Contributor

@johanrosenson johanrosenson commented Feb 15, 2021

The latest update breaks laravel installations unless you modify the config/honeybadger.php (if you have published it to your config directory), the latest update assumes that the verify option exists in the config, this is not the case if you are upgrading from honeybadger-laravel 3.4 (or older), so we need a null check here.

@johanrosenson johanrosenson changed the title add null check and default value add null check and default value for verify option Feb 15, 2021
@joshuap joshuap requested a review from sixlive February 15, 2021 22:41
@sixlive sixlive merged commit a74fa25 into honeybadger-io:master Feb 16, 2021
@sixlive
Copy link
Collaborator

sixlive commented Feb 16, 2021

Oh yikes! Sorry about this! Merged and tagged! https://github.com/honeybadger-io/honeybadger-php/releases/tag/v2.4.1

@johanrosenson johanrosenson deleted the config-null-check branch February 17, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants