Pass verify option to guzzle config #123
Conversation
I was having issues with the guzzle "verify" client option. By default HoneybaderClient sets "verify" to true. Sometimes this is NOT the best option because some developers do NOT have access to the php.ini or openssl configuration. https://docs.guzzlephp.org/en/stable/request-options.html#verify I commented on honeybadger-io#112 (honeybadger-io#112 (comment)) and @joshuap provided that another issue honeybadger-io#121 may be related. Took a little time and found that in Laravel the client configuration is not brought in generally, instead is specified with specific context as seen in lines 91-92. I've added the "verify" option that works from Laravel's honeybader configuration. Easy test is to set "verify" to false.
|
I'm really new to this process and am a paying $$$ customer. Found my solution and verified. This is really a patch. There seems to be an issue with merging the default configuration and the argument configuration that needs further investigation. And if this pull-request is accepted, you should probably update the documentation and add the |
sixlive
changed the title
|
@brantmessenger thanks for the PR I've cut a release of both the PHP and Laravel libs to account for SSL verification |
|
@sixlive glad I could help. Sorry again for not meeting your PR standard. Hope this helps everyone! |
The PR was great! I merged it! |
I was having issues with the guzzle "verify" client option. By default HoneybaderClient sets "verify" to true. Sometimes this is NOT the best option because some developers do NOT have access to the php.ini or openssl configuration. https://docs.guzzlephp.org/en/stable/request-options.html#verify
I commented on #112 (#112 (comment)) and @joshuap provided that another issue #121 may be related.
Took a little time and found that in Laravel the client configuration is not brought in generally, instead is specified with specific context as seen in lines 91-92.
I've added the "verify" option that works from Laravel's honeybader configuration. Easy test is to set "verify" to false.
Status
READY/WIP/HOLD
Description
A few sentences describing the overall goals of the pull request's commits.
Related PRs
List related PRs against other branches:
Todos
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.