Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment to custom and raw notifications #113

Merged
merged 2 commits into from
Sep 7, 2020
Merged

Add environment to custom and raw notifications #113

merged 2 commits into from
Sep 7, 2020

Conversation

roberttstephens
Copy link
Contributor

@roberttstephens roberttstephens commented Aug 3, 2020 •
edited
Loading

Description

While integrating this into drupal using https://github.com/nathandentzau/drupal-honeybadger and using a custom notification, I noticed that the environment name did not populate in the Honeybadger dashboard.

This PR will add the environment name to custom and raw notifications. It defaults to production because of https://github.com/honeybadger-io/honeybadger-php/blob/master/src/Config.php#L40 .

Related PRs

None

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit

@stympy stympy requested a review from sixlive August 3, 2020 16:37
@sixlive
Copy link
Collaborator

sixlive commented Aug 7, 2020

Is there any reason why this is WIP/Draft? Looks like its good to go!

@roberttstephens roberttstephens marked this pull request as ready for review August 9, 2020 00:02
@roberttstephens
Copy link
Contributor Author

@sixlive I was hoping to add some tests, but haven't been able to get around to it yet. Feel free to merge if you think it's ready, though!

@sixlive sixlive merged commit 6b1baf1 into honeybadger-io:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sixlive sixlive Awaiting requested review from sixlive

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roberttstephens @sixlive