Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handler exception mapping #104

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Fix error handler exception mapping #104

merged 2 commits into from
Feb 10, 2020

Conversation

sixlive
Copy link
Collaborator

@sixlive sixlive commented Feb 10, 2020

Description

The order of arguments for mapping the error handler to an
ErrorException were inverted for argument 2 and 3.

Reference https://www.php.net/manual/en/class.errorexception.php

@sixlive
Fix error handler exception mapping
da47dcc 
The order of arguments for mapping the error handler to an
ErrorException were inverted for argument 2 and 3.
@sixlive sixlive requested a review from stympy February 10, 2020 14:58
@sixlive sixlive self-assigned this Feb 10, 2020
stympy
stympy approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@stympy stympy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sixlive sixlive merged commit 47c9366 into honeybadger-io:master Feb 10, 2020
@sixlive sixlive deleted the fix-error-exception-mapping branch February 10, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stympy stympy stympy approved these changes

Assignees

@sixlive sixlive

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sixlive @stympy