fix: Destroy textures to fix memory leak #1337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishigurobot
changed the title
homuler
reviewed
Feb 18, 2025
Packages/com.github.homuler.mediapipe/Runtime/Scripts/Unity/Experimental/TextureFrame.cs
Outdated
Show resolved
Hide resolved
…perimental/TextureFrame.cs Co-authored-by: Junrou Nishida <[email protected]>
Contributor
Author
|
Sorry, I found more implementations are needed, and I've just pushed it now. If you want to call Stop() automatically, you have to implement OnDestroy() somewhere else, I think. |
homuler
changed the title
homuler
approved these changes
Feb 18, 2025
Contributor
Author
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this nice plugin!
I found a memory leak problem and it cause runtime crash on iPhone.
It happens when I repeat Instantiate and Destroy components (ex. Holistic solution) via my script.
In memory profiler, Texture2D was increasing and leaking,
and those textures seem to have been generated by TextureFrames.
After adding Destroy() in
Packages/com.github.homuler.mediapipe/Runtime/Scripts/Unity/Experimental/TextureFrame.cs, it's fixed.I confirmed about
Packages/com.github.homuler.mediapipe/Runtime/Scripts/Unity/Experimental/TextureFrame.cs, but I don't know how should I do aboutAssets/MediaPipeUnity/Samples/Common/Scripts/ImageSource/TextureFrame.cs.This Pull Request is just for your information.