-
Notifications
You must be signed in to change notification settings - Fork 65
Refactor build to use artifacts #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the build and release workflow to use GitHub Actions artifacts for storing work-in-progress builds instead of uploading to releases directly. It also includes improvements to the release body generation script with better quoting and logging.
Key Changes
- Shifted from release-based to artifact-based workflow for intermediate build outputs
- Added artifact download/upload logic with error handling for optional build variants
- Fixed shell script quoting issues and added debug logging in the release body builder
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
.github/workflows/release-stage-3_package_release.yml |
Completely refactored to download artifacts from stage 2 builds instead of release assets, combines outputs, and creates the final release |
.github/workflows/create_raspbian_pi-gen.yml |
Updated to upload build outputs as artifacts instead of directly to releases; triggers stage 3 workflow with run metadata |
.github/workflows/release-stage-1_update_dependencies.yml |
Updated checkout action from v4 to v5 |
scripts/create-release-body.sh |
Added proper quoting around variables and added debug logging for manifest comparison |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Minor refactor of build
1 - Change of approach from using a release to store work in progress releases, to now use artifacts to hold inflight materials.
2 - Fix minor issues with release body builder