-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Add Installer login, Add ManualCharge Switch #36472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe pull request updates the documentation for the Kostal Plenticore integration by adding a new "Installer access" section. This section explains how users can enable installer-level access using a Master key and Service Code, including warnings about potential risks and instructions for configuration. Changes
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
source/_integrations/kostal_plenticore.markdown (1)
24-24: Consider reorganizing installer-related documentation.To improve documentation structure and readability, consider:
- Creating a dedicated "Installer Features" section
- Moving all installer-related content under this section
- Cross-referencing between related sections
This would help users better understand which features require installer access and their relationships.
Also applies to: 151-151
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/kostal_plenticore.markdown (3)
25-42: Enhance technical details for installer access documentation.While the warning section effectively communicates the risks, the documentation would benefit from additional technical details:
- Where in the Home Assistant UI users can enter installer credentials
- Expected format of the Master key and Service Code
- Step-by-step process for enabling installer access
Consider adding a new subsection with these technical details:
For information about obtaining installer credentials, please consult your device documentation or contact a certified installer. + +### Enabling Installer Access + +1. Navigate to [specify location in HA UI] +2. Enter your Master key (format: [specify format]) +3. Enter your Service Code (format: [specify format]) +4. [Additional steps if any]🧰 Tools
🪛 Markdownlint (0.37.0)
25-25: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
27-27: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
29-29: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
30-30: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
31-31: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
32-32: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
33-33: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
34-34: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
35-35: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
37-37: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
39-39: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
40-40: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
31-31: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
40-40: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
169-169: Expand Battery Manual Charge documentation with technical details.The current description covers the basics but would benefit from additional technical information:
- Available states/values for this setting
- Relationship with other battery settings (e.g., Battery Strategy, Battery Smart Control)
- Typical maintenance scenarios when this should be used
- Duration limits or automatic safety cutoffs
Consider expanding the description:
-| Battery Manual Charge | | RW | Enables manual charging of the battery for service purposes. This feature: <br>- Requires installer login credentials<br>- Allows forcing battery charging regardless of normal charging rules<br>- Should only be used for maintenance/service purposes<br>- May impact battery longevity if used incorrectly | +| Battery Manual Charge | | RW | Enables manual charging of the battery for service purposes. This feature: <br>- Requires installer login credentials<br>- Allows forcing battery charging regardless of normal charging rules<br>- Available states: [list states]<br>- Automatically disables after [duration] or when [condition]<br>- Typical use cases:<br> * Battery maintenance<br> * Capacity testing<br> * [other scenarios]<br>- Interacts with:<br> * Battery Strategy setting<br> * Battery Smart Control setting<br>- Should only be used for maintenance/service purposes<br>- May impact battery longevity if used incorrectly |
25-42: Fix markdown formatting issues.There are several minor formatting issues in the new sections:
- Remove trailing spaces at the end of lines
- Add blank lines around lists
Apply these formatting fixes:
-## Installer Access +## Installer Access -The integration supports installer-level access using a Master key and Service Code. This enables access to additional settings that are normally restricted to certified installers. +The integration supports installer-level access using a Master key and Service Code. This enables access to additional settings that are normally restricted to certified installers. -{% warning %} +{% warning %} + -Using installer credentials: +Using installer credentials: + - Should only be done if you fully understand the implications - May void your warranty - Could potentially damage your device if settings are incorrectly configured - Should be done with extreme caution + {% endwarning %}🧰 Tools
🪛 Markdownlint (0.37.0)
25-25: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
27-27: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
29-29: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
30-30: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
31-31: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
32-32: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
33-33: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
34-34: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
35-35: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
37-37: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
39-39: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
40-40: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
31-31: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
40-40: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/kostal_plenticore.markdown(2 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
source/_integrations/kostal_plenticore.markdown
25-25: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
27-27: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
29-29: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
30-30: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
31-31: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
32-32: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
33-33: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
34-34: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
35-35: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
37-37: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
39-39: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
40-40: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
31-31: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
40-40: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
source/_integrations/kostal_plenticore.markdown (1)
33-45: Fix markdown formatting inconsistenciesRemove trailing spaces at the end of lines to maintain consistent formatting.
-Using installer credentials: +Using installer credentials: -- Should only be done if you fully understand the implications -- May void your warranty -- Could potentially damage your device if settings are incorrectly configured -- Should be done with extreme caution +- Should only be done if you fully understand the implications +- May void your warranty +- Could potentially damage your device if settings are incorrectly configured +- Should be done with extreme caution🧰 Tools
🪛 LanguageTool
[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...(MISSING_IT_THERE)
🪛 Markdownlint (0.37.0)
33-33: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
34-34: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
35-35: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
36-36: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
38-38: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
40-40: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
42-42: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
44-44: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
45-45: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
45-45: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/kostal_plenticore.markdown(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/kostal_plenticore.markdown
[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...
(MISSING_IT_THERE)
🪛 Markdownlint (0.37.0)
source/_integrations/kostal_plenticore.markdown
33-33: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
34-34: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
35-35: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
36-36: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
38-38: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
40-40: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
42-42: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
44-44: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
45-45: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
45-45: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🔇 Additional comments (1)
source/_integrations/kostal_plenticore.markdown (1)
174-174: 🛠️ Refactor suggestion
Expand Battery Manual Charge documentation with technical details
The current documentation needs more technical details about this critical feature:
-| Battery Manual Charge | | RW | Enables manual charging of the battery for service purposes. This feature: <br>- Requires installer login credentials<br>- Allows forcing battery charging regardless of normal charging rules<br>- Should only be used for maintenance/service purposes<br>- May impact battery longevity if used incorrectly |
+| Battery Manual Charge | | RW | Enables manual charging of the battery for service purposes. This feature: <br>- Requires installer login credentials<br>- Available states: [list all possible states]<br>- Charging behavior:<br> • Overrides normal charging rules<br> • [Describe charging parameters]<br> • [Describe any limits/thresholds]<br>- Safety considerations:<br> • Automatic timeout: [specify duration]<br> • Temperature monitoring: [describe limits]<br> • Emergency cutoff: [describe conditions]<br>- Monitoring requirements:<br> • Recommended sensors to monitor<br> • Warning indicators<br> • Logging requirements |Likely invalid or redundant comment.
| ## Installer Access | ||
|
|
||
| The integration supports installer-level access using a Master key and Service Code. This enables access to additional settings that are normally restricted to certified installers. | ||
|
|
||
| {% warning %} | ||
|
|
||
| Using installer credentials: | ||
|
|
||
| - Should only be done if you fully understand the implications | ||
| - May void your warranty | ||
| - Could potentially damage your device if settings are incorrectly configured | ||
| - Should be done with extreme caution | ||
|
|
||
| {% endwarning %} | ||
|
|
||
| To enable installer access, set your Master Key as the password and fill in the Service Code in the configuration when adding the integration. | ||
|
|
||
| ### Additional Settings with Installer Access | ||
|
|
||
| The following settings become available when using installer credentials: | ||
| - Battery Manual Charge | ||
|
|
||
| For information about obtaining installer credentials, please consult your device documentation or contact a certified installer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Enhance installer access documentation with additional critical details
While the current documentation provides a good foundation, please add the following essential information:
- What is a Master key and how does it differ from a regular password?
- Format/requirements for the Service Code
- Complete list of settings that become accessible with installer credentials
- Impact on system behavior when using installer access
- Any logging or monitoring considerations
To enable installer access, set your Master Key as the password and fill in the Service Code in the configuration when adding the integration.
### Additional Settings with Installer Access
The following settings become available when using installer credentials:
-Battery Manual Charge
+- Battery Manual Charge: Enables service-level battery charging operations
+- [List other installer-only settings with descriptions]
+
+### Technical Details
+
+- Master Key: [Explain what it is and its format]
+- Service Code: [Explain format and requirements]
+
+### System Impact
+
+When using installer access:
+- System behavior changes: [List specific changes]
+- Additional logging: [Describe any special logging]
+- Monitoring considerations: [Any special monitoring needs]Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 LanguageTool
[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...
(MISSING_IT_THERE)
🪛 Markdownlint (0.37.0)
33-33: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
34-34: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
35-35: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
36-36: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
38-38: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
40-40: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
42-42: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
44-44: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
45-45: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
45-45: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
source/_integrations/kostal_plenticore.markdown (1)
25-28: 🛠️ Refactor suggestionProvide comprehensive list of installer-only features
The section introduces installer access but doesn’t list what settings become available. At minimum, document the new ManualCharge Switch (and any other installer-only settings). For example, you could expand the section as follows:## Installer Access -The integration supports installer-level access using a Master key and Service Code. This enables access to future additional settings that are normally restricted to certified installers. +The integration supports installer-level access using a Master Key and Service Code. This enables access to additional advanced settings that are normally restricted to certified installers. + +### Installer-Only Features +- **ManualCharge Switch**: Enables service-mode battery charging when installer access is active. +- **Battery Manual Charge**: Forces battery charging regardless of normal rules. +- [List any other installer-only settings here]
🧹 Nitpick comments (3)
source/_integrations/kostal_plenticore.markdown (3)
29-38: Clean up warning block formatting and grammar
There are trailing spaces, missing blank lines around the list, and fragmentary bullets. Converting them into full sentences and fixing spacing will improve readability:{% warning %} -Using installer credentials: - -- Should only be done if you fully understand the implications -- May void your warranty -- Could potentially damage your device if settings are incorrectly configured -- Should be done with extreme caution - -{% endwarning %} +Using installer credentials: + +- You should only do this if you fully understand the implications. +- It may void your inverter warranty. +- It could damage your device if settings are misconfigured. +- Proceed with extreme caution. + +{% endwarning %}🧰 Tools
🪛 LanguageTool
[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...(MISSING_IT_THERE)
[uncategorized] ~36-~36: A period might be missing here.
Context: ...nfigured - Should be done with extreme caution {% endwarning %} To enable installe...(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)
🪛 markdownlint-cli2 (0.17.2)
33-33: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
34-34: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
35-35: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
36-36: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
38-38: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
40-40: Add a configuration snippet for clarity
Users need concrete examples to know where to enter their Master Key and Service Code. Consider adding a YAML snippet:```yaml kostal_plenticore: host: 192.168.1.100 username: YOUR_MASTER_KEY password: YOUR_PASSWORD service_code: YOUR_SERVICE_CODE<details> <summary>🧰 Tools</summary> <details> <summary>🪛 markdownlint-cli2 (0.17.2)</summary> 40-40: Trailing spaces Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces) </details> </details> --- `42-43`: **Link to official service documentation** Rather than a generic referral, include a direct link or specify the format of the Service Code: ```diff -For information about obtaining installer credentials, please consult your device documentation or contact a certified installer. +For details on obtaining installer credentials, see the [Kostal Plenticore service documentation](https://www.kostal-solar-electric.com/en/service-downloads/) or contact a certified installer.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/kostal_plenticore.markdown(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/kostal_plenticore.markdown
[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...
(MISSING_IT_THERE)
[uncategorized] ~36-~36: A period might be missing here.
Context: ...nfigured - Should be done with extreme caution {% endwarning %} To enable installe...
(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/kostal_plenticore.markdown
33-33: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
34-34: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
35-35: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
36-36: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
38-38: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
40-40: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
source/_integrations/kostal_plenticore.markdown (1)
27-28: List installer-only settings
It would be helpful to enumerate the actual settings available with installer access (e.g., the ManualCharge Switch / Battery Manual Charge, etc.).## Installer access + +### Additional settings available with installer access +- Battery Manual Charge (ManualCharge Switch) +- [List other installer-only settings here]
🧹 Nitpick comments (3)
source/_integrations/kostal_plenticore.markdown (3)
27-27: Clarify phrasing by removing “future”
The phrase “future additional settings” can be misleading. Consider simplifying:-The integration supports installer-level access using a Master key and Service Code. This enables access to future additional settings that are normally restricted to certified installers. +The integration supports installer-level access using a Master key and Service Code. This enables access to additional settings that are normally restricted to certified installers.
29-38: Refine warning block for clarity and cleanup whitespace
- Change “Using installer credentials:” to “When using installer credentials:” for a complete phrase.
- Remove trailing spaces and add periods to list items.
-{% warning %} - -Using installer credentials: - -- Should only be done if you fully understand the implications -- May void your warranty -- Could potentially damage your device if settings are incorrectly configured -- Should be done with extreme caution -{% endwarning %} +{% warning %} + +When using installer credentials: + +- Should only be done if you fully understand the implications. +- May void your warranty. +- Could potentially damage your device if settings are incorrectly configured. +- Should be done with extreme caution. +{% endwarning %}🧰 Tools
🪛 LanguageTool
[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...(MISSING_IT_THERE)
[uncategorized] ~36-~36: A period might be missing here.
Context: ...nfigured - Should be done with extreme caution {% endwarning %} To enable installe...(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)
🪛 markdownlint-cli2 (0.17.2)
33-33: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
34-34: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
35-35: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
36-36: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
38-38: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
40-40: Optional: clarify configuration flow wording
You might make the instruction more precise by referencing the config flow:-To enable installer access, set your Master Key as the password and fill in the Service Code in the configuration when adding the integration. +To enable installer access, enter your Master Key as the password and provide the Service Code during the integration’s configuration flow.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
40-40: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/kostal_plenticore.markdown(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/kostal_plenticore.markdown
[style] ~33-~33: To form a complete sentence, be sure to include a subject.
Context: ...ing %} Using installer credentials: - Should only be done if you fully understand th...
(MISSING_IT_THERE)
[uncategorized] ~36-~36: A period might be missing here.
Context: ...nfigured - Should be done with extreme caution {% endwarning %} To enable installe...
(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/kostal_plenticore.markdown
33-33: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
34-34: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
35-35: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
36-36: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
38-38: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
40-40: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/kostal_plenticore.markdown (2)
25-25: Heading style is correct
The new section title uses sentence-style capitalization as per Home Assistant documentation guidelines.
42-42: Approval: credential sourcing guidance
The guidance to consult device documentation or a certified installer is clear and sufficient.
requested comment has been implemented
c0ffeeca7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Schlauer-Hax 👍
Proposed change
This change makes it possible to use a installer login with kostal plenticore. It enables access to more settings that are not available from the normal login. The change also adds the ManualCharge Switch which activates Service Charging. This Switch can only be set when the installer login is active.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.Summary by CodeRabbit
New Features
Documentation