Use Generator and AsyncGenerator for contextmanager typing#162144
Merged
cdce8p merged 1 commit intohome-assistant:devfrom Feb 3, 2026
Merged
Use Generator and AsyncGenerator for contextmanager typing#162144cdce8p merged 1 commit intohome-assistant:devfrom
cdce8p merged 1 commit intohome-assistant:devfrom
Conversation
cdce8p
requested review from
a team,
Adminiuga,
TheJulianJES,
bdraco,
bieniu,
chemelli74,
dmulcahey,
elupus,
emontnemery,
puddly and
thecode
as code owners
home-assistant
bot
added
cla-signed
code-quality
core
small-pr
bdraco
approved these changes
Feb 3, 2026
epenet
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Any function decorated with
contextmanager/asynccontextmanagershould useGenerator/AsyncGeneratoras return annotation (instead ofIterator/AsyncIterator). This will be a warning in the next mypy release.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: