Skip to content

Bump grpcio to 1.72.0 and protobuf to 6.30.2#143633

Merged
bdraco merged 7 commits intodevfrom
grpcio_1720
May 19, 2025
Merged

Bump grpcio to 1.72.0 and protobuf to 6.30.2#143633
bdraco merged 7 commits intodevfrom
grpcio_1720

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 24, 2025 •
edited
Loading

Proposed change

Note these must be bumped together since grpcio-status requires a newer protobuf

changelogs: grpc/grpc@v1.71.1...v1.72.0 protocolbuffers/protobuf@v29.2...v30.2

TODO:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core dependency Pull requests marked as a dependency upgrade small-pr PRs with less than 30 lines. labels Apr 24, 2025
@bdraco bdraco mentioned this pull request Apr 24, 2025
Closed
27 tasks
@bdraco bdraco changed the title Bump grpcio to 1.72.0 Bump grpcio to 1.72.0 and protobuf to 6.30.2 Apr 25, 2025
@bdraco bdraco mentioned this pull request Apr 25, 2025
Closed
@sdb9696 sdb9696 mentioned this pull request May 10, 2025
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented May 18, 2025 •
edited
Loading

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 1418 at 1:417173 in /home/runner/work/core/core/test-results-full-3.13-7/junit.xml

@bdraco bdraco marked this pull request as ready for review May 19, 2025 00:08
@bdraco bdraco requested a review from a team as a code owner May 19, 2025 00:08
@bdraco bdraco merged commit eb4d561 into dev May 19, 2025
48 checks passed
@bdraco bdraco deleted the grpcio_1720 branch May 19, 2025 00:10
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
@joostlek
Copy link
Copy Markdown
Member

joostlek commented May 20, 2025 

warning: `grpcio==1.72.0` is yanked (reason: "Missing cp312 macosx universal2 wheel")
warning: `grpcio-reflection==1.72.0` is yanked (reason: "grpcio Missing cp312 macosx universal2 wheel")
warning: `grpcio-status==1.72.0` is yanked (reason: "grpcio Missing cp312 macosx universal2 wheel")

@home-assistant home-assistant unlocked this conversation May 20, 2025
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 20, 2025

AFAIK there isn't anything wrong with the build other than the old x86_64 macOS build is missing so there are no concerns about using it other than x86_64 macOS wheels would need to be built locally. If we are concerned about that, then we should revert

@joostlek
Copy link
Copy Markdown
Member

joostlek commented May 20, 2025

Yea just wanted to flag it, I also did not know if this has any other impact on the build process

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 20, 2025

It looks like it's only missing for 3.12. There is a universal wheel for macOS 3.13

@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

Assignees

No one assigned

Labels

cla-signed core dependency Pull requests marked as a dependency upgrade small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bdraco @joostlek @balloob @MartinHjelmare