Skip to content

DNM: Prepare for protobuf 6#137736

Closed
bdraco wants to merge 9 commits intodevfrom
prepare_protobuf6
Closed

DNM: Prepare for protobuf 6#137736
bdraco wants to merge 9 commits intodevfrom
prepare_protobuf6

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 7, 2025

Proposed change

This PR is to see what will break. Hopefully nothing as the breaking changes are more about the old cpp APIs as well as long standing deprecation removals and we haven't used them for a while. protocolbuffers/protobuf@9e44913 fixes a performance issue for aioesphomeapi

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

This PR is to see what will break
@home-assistant home-assistant bot added cla-signed core dependency-bump Pull requests that update a dependency file small-pr PRs with less than 30 lines. labels Feb 7, 2025
bdraco added a commit to esphome/aioesphomeapi that referenced this pull request Feb 7, 2025
bdraco added a commit to esphome/aioesphomeapi that referenced this pull request Feb 7, 2025
bdraco added a commit to Bluetooth-Devices/bleak-esphome that referenced this pull request Feb 7, 2025
@bdraco bdraco added the dependency Pull requests marked as a dependency upgrade label Feb 7, 2025
bdraco added a commit that referenced this pull request Feb 7, 2025
changelog: googleapis/python-pubsub@v2.23.0...v2.28.0

getting this updates so it will be a smaller bump once
protobuf 6 is supported #137736
@bdraco bdraco mentioned this pull request Feb 7, 2025
19 tasks
frenck pushed a commit that referenced this pull request Feb 9, 2025
changelog: googleapis/python-pubsub@v2.23.0...v2.28.0

getting this updates so it will be a smaller bump once
protobuf 6 is supported #137736
@bdraco bdraco mentioned this pull request Mar 30, 2025
19 tasks
bdraco added a commit that referenced this pull request Mar 30, 2025
@bdraco bdraco mentioned this pull request Mar 30, 2025
19 tasks
@Bre77
Copy link
Copy Markdown
Contributor

Bre77 commented May 20, 2025

Can you add tesla_fleet_api to your concern, I upgraded it to 6 and then had to roll it back to 5.29.2. I dont have any specific need to be on one version or the other, but will just been to update my library when required for this PR.

EDIT: Oh if things are backwards compatible I guess I just wait for this to merge and then do my own updates.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 20, 2025

Sorry we already updated to protobuf 6. I forgot to close this PR as it got done in another one.

@bdraco bdraco closed this May 20, 2025
@bdraco bdraco deleted the prepare_protobuf6 branch May 20, 2025 05:01
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core dependency Pull requests marked as a dependency upgrade dependency-bump Pull requests that update a dependency file small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants