Address warnings emitted by the unit tests suite #1700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
reviewed
Dec 17, 2025
| # be adapted for Dask. | ||
| self.data = data.stack().reset_index(1).rename(columns={'level_1': group_label}) | ||
| self.data = ( | ||
| data.stack(future_stack=True) |
Member
There was a problem hiding this comment.
I don't think this is backward compatible for all supported versions of pandas. It looks like this was added in Pandas 2.1, and we support down to 1.3.
Member
Author
There was a problem hiding this comment.
we support down to 1.3
Hmm this is just a lower pin in the pyproject.toml. In practice, I have no clue what the real lower pin is, until testing with lower pins is enabled. But yes I'll add compatibility code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One code change is that we no longer try to parse a crs with
pyproj.Proj(init=crs, preserve_units=True)as this is deprecated in pyproj.