Compatibility with the latest versions of DuckDB #1682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
It was done in 1.4.1. FWIW. |
hoxbro
reviewed
Oct 10, 2025
doc/conftest.py
Outdated
|
|
||
| # 'Ibis <= 10.8.0 is incompatible with DuckDB >= 1.4') | ||
| if parse(ibis.__version__) <= parse('10.8.0') and parse(duckdb.__version__) >= parse('1.4'): | ||
| collect_ignore_glob += ['doc/ref/data_libraries.ipynb'] |
Member
There was a problem hiding this comment.
Suggested change
| collect_ignore_glob += ['doc/ref/data_libraries.ipynb'] | |
| collect_ignore_glob += ['ref/data_libraries.ipynb'] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
piptests (scheduled to run weekly) started to fail with the last release of duckdb. Somehow I haven't been able to find their changelog. The changes made in this PR:is_duckdbreturned False with the newest versions, as the module is not called_duckdband notduckdbduckdb.typingmodule. I assumed this was done in 1.4.0 (current is 1.4.1)Additionally, one ibis test was failing as it uses duckdb as its internal in-memory backed, and they haven't yet released a version compatible with the latest duckdb. The issue I was facing is fixed in ibis-project/ibis#11666 but not yet released. So the test is skipped, assuming the next release of ibis will be compatible.