Skip to content

Fix setting xaxis/yaxis #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maximlt merged 1 commit into from
Mar 15, 2025
Merged

Fix setting xaxis/yaxis #1497

maximlt merged 1 commit into from
Mar 15, 2025

Conversation

@maximlt
Copy link
Member

@maximlt maximlt commented Feb 13, 2025

Fixes #1442

@maximlt maximlt requested review from ahuang11 and philippjfr and removed request for philippjfr February 13, 2025 20:13
@maximlt maximlt mentioned this pull request Feb 13, 2025
Closed
@ahuang11
Copy link
Collaborator

ahuang11 commented Mar 15, 2025 •
edited
Loading

Not sure if the docs are updated yet in a separate PR, but there's also 'bare' and None

xaxis/yaxis: str or None
Whether to show the x/y-axis and whether to place it at the
'top'/'bottom' and 'left'/'right' respectively.

@maximlt
Copy link
Member Author

maximlt commented Mar 15, 2025

Yes, you're right, thanks for spotting that! Let's fix it in another PR. The docstring is not missing more options:

    xaxis = param.Selector(default='bottom',
                                 objects=['top', 'bottom', 'bare', 'top-bare',
                                          'bottom-bare', None, True, False], doc="""
        Whether and where to display the xaxis.
        The "bare" options allow suppressing all axis labels, including ticks and xlabel.
        Valid options are 'top', 'bottom', 'bare', 'top-bare' and 'bottom-bare'.""")

    yaxis = param.Selector(default='left',
                                      objects=['left', 'right', 'bare', 'left-bare',
                                               'right-bare', None, True, False], doc="""
        Whether and where to display the yaxis.
        The "bare" options allow suppressing all axis labels, including ticks and ylabel.
        Valid options are 'left', 'right', 'bare', 'left-bare' and 'right-bare'.""")

@maximlt maximlt merged commit c48ab94 into main Mar 15, 2025
11 checks passed
@maximlt maximlt deleted the fix_setting_axis branch March 15, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahuang11 ahuang11 ahuang11 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow setting xaxis/yaxis as string

3 participants

@maximlt @ahuang11