Explorer: disable the geo controls when geoviews is not installed #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuang11
approved these changes
Dec 21, 2023
Collaborator
There was a problem hiding this comment.
Looks good to me! The only thing is tiles doesn't seem to work without geographic projections, but I think that's a separate issue.
e.g. need to call: lon_lat_to_easting_northing
import holoviews as hv
hv.extension("bokeh")
hv.element.tiles.EsriImagery() * hv.Points(
hv.util.transform.lon_lat_to_easting_northing(-88, 40)
)
Member
Author
|
@ahuang11 Isn't it that you need to provide a dataset that has coordinates already projected to easting/northing to use |
Collaborator
|
Maybe an extra toggle in the future that allows conversion to easting northing? Or at the very least, a tooltip that elaborates on that so new users aren't confused. |
Member
Author
|
Yes I think that'd make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing (a tiny) part of #1190 with a different take compared to #1200 whose goal is to cover all kind of exceptions the explorer might raise, while in this PR I focused on finding the best way to let them know they should install GeoViews to enable the geo controls.
I ended up trying to import geoviews on initialization and if that fails disabling all the geo controls:
The
Checkboxwidget has no tooltip so instead I used a Toggle with a label that is updated to indicate GeoViews is required.Trying to instantiate an explorer by passing geo kwargs (e.g.
df.explorer(geo=True)) will raise an import error.