Parse options w/ option for overriding owner matchers#23
Closed
Conversation
|
Thank you very much! "Allow edits from maintainers" is checked in my PR. |
Owner
Author
|
@haveachin thanks, I've pushed my commit to your fork so I'll close this PR our and we can continue the conversation in #19. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@haveachin - this takes #19 and adds a commit that
MatchertoOwnerMatcheras "matcher" is already used widely in the codebase for matching codeowners patternsParseFileto accept parse options (e.g.WithOwnerMatchers) rather than the matchers themselves, as it's likely we'll want to add more parser options in the future (e.g. to support the GitLab sections syntax)Thanks for your PR—have a look at these changes and LMK what you think. I'm also happy to push the commit to your branch if you turn on the "Allow edits from maintainers" flag.