Don't allow [] characters in patterns

hmarr · hmarr · commit 8e6721a090e6 · 2021-03-28T14:21:45.000-04:00
diff --git a/parse.go b/parse.go
@@ -171,7 +171,7 @@ func isAlphanumeric(ch rune) bool {
 // isPatternChar matches characters that are allowed in patterns
 func isPatternChar(ch rune) bool {
 	switch ch {
-	case '*', '?', '.', '/', '@', '_', '+', '-', '[', ']', '\\':
+	case '*', '?', '.', '/', '@', '_', '+', '-', '\\':
 		return true
 	}
 	return isAlphanumeric(ch)
diff --git a/parse_test.go b/parse_test.go
@@ -52,9 +52,9 @@ func TestParseRule(t *testing.T) {
 		},
 		{
 			name: "complex patterns",
-			rule: "[d]?r/* @user",
+			rule: "d?r/* @user",
 			expected: Rule{
-				pattern: mustBuildPattern(t, "[d]?r/*"),
+				pattern: mustBuildPattern(t, "d?r/*"),
 				Owners:  []Owner{{Value: "user", Type: "username"}},
 			},
 		},
@@ -92,6 +92,11 @@ func TestParseRule(t *testing.T) {
 			rule: "file.{txt @user",
 			err:  "unexpected character '{' at position 6",
 		},
+		{
+			name: "patterns with brackets",
+			rule: "file.[cC] @user",
+			err:  "unexpected character '[' at position 6",
+		},
 		{
 			name: "malformed owners",
 			rule: "file.txt missing-at-sign",

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ func isAlphanumeric(ch rune) bool {`
`171`	`171`	`// isPatternChar matches characters that are allowed in patterns`
`172`	`172`	`func isPatternChar(ch rune) bool {`
`173`	`173`	`switch ch {`
`174`		`- case '*', '?', '.', '/', '@', '_', '+', '-', '[', ']', '\\':`
	`174`	`+ case '*', '?', '.', '/', '@', '_', '+', '-', '\\':`
`175`	`175`	`return true`
`176`	`176`	`}`
`177`	`177`	`return isAlphanumeric(ch)`