fix(tui): prevent extra row appearing in blocking picker on toggle

hmans · hmans · commit cea0a192e6fb · 2025-12-13T00:43:36.000+01:00
Create a new slice when updating items instead of modifying the slice
returned by list.Items() in place, which was corrupting internal state.
diff --git a/internal/tui/blockingpicker.go b/internal/tui/blockingpicker.go
@@ -209,17 +209,18 @@ func (m blockingPickerModel) Update(msg tea.Msg) (blockingPickerModel, tea.Cmd)
 					}
 
 					// Update the list items to reflect new state
-					items := m.list.Items()
-					for i, listItem := range items {
+					oldItems := m.list.Items()
+					newItems := make([]list.Item, len(oldItems))
+					for i, listItem := range oldItems {
 						if bi, ok := listItem.(blockingItem); ok {
-							items[i] = blockingItem{
+							newItems[i] = blockingItem{
 								bean:       bi.bean,
 								cfg:        bi.cfg,
 								isBlocking: m.pendingBlocking[bi.bean.ID],
 							}
 						}
 					}
-					m.list.SetItems(items)
+					m.list.SetItems(newItems)
 
 					// Restore selection position
 					m.list.Select(currentIndex)

Original file line number	Diff line number	Diff line change
`@@ -209,17 +209,18 @@ func (m blockingPickerModel) Update(msg tea.Msg) (blockingPickerModel, tea.Cmd)`
`209`	`209`	`}`
`210`	`210`
`211`	`211`	`// Update the list items to reflect new state`
`212`		`- items := m.list.Items()`
`213`		`- for i, listItem := range items {`
	`212`	`+ oldItems := m.list.Items()`
	`213`	`+ newItems := make([]list.Item, len(oldItems))`
	`214`	`+ for i, listItem := range oldItems {`
`214`	`215`	`if bi, ok := listItem.(blockingItem); ok {`
`215`		`- items[i] = blockingItem{`
	`216`	`+ newItems[i] = blockingItem{`
`216`	`217`	`bean: bi.bean,`
`217`	`218`	`cfg: bi.cfg,`
`218`	`219`	`isBlocking: m.pendingBlocking[bi.bean.ID],`
`219`	`220`	`}`
`220`	`221`	`}`
`221`	`222`	`}`
`222`		`- m.list.SetItems(items)`
	`223`	`+ m.list.SetItems(newItems)`
`223`	`224`
`224`	`225`	`// Restore selection position`
`225`	`226`	`m.list.Select(currentIndex)`