feat: make beans list responsive to terminal width

hmans · hmans · commit 769fba8513d8 · 2025-12-13T13:26:38.000+01:00
- Detect terminal width using golang.org/x/term (fallback to 80)
- Use shared CalculateResponsiveColumns() from TUI
- Show tags column when terminal is wide enough
- Calculate title width dynamically based on available space
- Fix line wrapping by accounting for priority symbol and spacing
diff --git a/.beans/beans-ukdq--make-beans-list-responsive-to-terminal-width.md b/.beans/beans-ukdq--make-beans-list-responsive-to-terminal-width.md
@@ -0,0 +1,23 @@
+---
+title: Make beans list responsive to terminal width
+status: completed
+type: feature
+priority: normal
+created_at: 2025-12-13T11:56:39Z
+updated_at: 2025-12-13T12:12:18Z
+---
+
+Add terminal width detection to the CLI list command so it can adjust its output (column widths, tags visibility) similar to how the TUI does it.
+
+## Approach
+1. Detect terminal width using golang.org/x/term
+2. Use existing CalculateResponsiveColumns() function from internal/ui/styles.go
+3. Update RenderTree to accept and use responsive columns
+4. Pass calculated columns through to RenderBeanRow
+
+## Checklist
+- [ ] Add terminal width detection to cmd/list.go
+- [ ] Update RenderTree signature to accept terminal width
+- [ ] Calculate responsive columns in RenderTree
+- [ ] Pass responsive column config to RenderBeanRow calls
+- [ ] Test with various terminal widths
diff --git a/cmd/list.go b/cmd/list.go
@@ -3,6 +3,7 @@ package cmd
 import (
 	"context"
 	"fmt"
+	"os"
 	"sort"
 
 	"github.com/hmans/beans/internal/bean"
@@ -12,6 +13,7 @@ import (
 	"github.com/hmans/beans/internal/output"
 	"github.com/hmans/beans/internal/ui"
 	"github.com/spf13/cobra"
+	"golang.org/x/term"
 )
 
 var (
@@ -159,7 +161,13 @@ Search Syntax (--search/-S):
 			}
 		}
 
-		fmt.Print(ui.RenderTree(tree, cfg, maxIDWidth, hasTags))
+		// Detect terminal width (default to 80 if not a terminal)
+		termWidth := 80
+		if w, _, err := term.GetSize(int(os.Stdout.Fd())); err == nil && w > 0 {
+			termWidth = w
+		}
+
+		fmt.Print(ui.RenderTree(tree, cfg, maxIDWidth, hasTags, termWidth))
 		return nil
 	},
 }
diff --git a/go.mod b/go.mod
@@ -18,6 +18,7 @@ require (
 	github.com/spf13/cobra v1.10.2
 	github.com/tidwall/pretty v1.2.1
 	github.com/vektah/gqlparser/v2 v2.5.31
+	golang.org/x/term v0.38.0
 	gopkg.in/yaml.v3 v3.0.1
 )
 
@@ -92,7 +93,6 @@ require (
 	golang.org/x/net v0.48.0 // indirect
 	golang.org/x/sync v0.19.0 // indirect
 	golang.org/x/sys v0.39.0 // indirect
-	golang.org/x/term v0.38.0 // indirect
 	golang.org/x/text v0.32.0 // indirect
 	golang.org/x/tools v0.39.0 // indirect
 	google.golang.org/protobuf v1.36.10 // indirect
diff --git a/internal/ui/tree.go b/internal/ui/tree.go
@@ -169,7 +169,8 @@ func calculateMaxDepth(nodes []*TreeNode) int {
 }
 
 // RenderTree renders the tree as an ASCII tree with styled columns.
-func RenderTree(nodes []*TreeNode, cfg *config.Config, maxIDWidth int, hasTags bool) string {
+// termWidth is used to calculate responsive column widths.
+func RenderTree(nodes []*TreeNode, cfg *config.Config, maxIDWidth int, hasTags bool, termWidth int) string {
 	var sb strings.Builder
 
 	// Calculate max depth to determine ID column width
@@ -184,48 +185,79 @@ func RenderTree(nodes []*TreeNode, cfg *config.Config, maxIDWidth int, hasTags b
 		treeColWidth = maxIDWidth + maxDepth*treeIndent
 	}
 
+	// Calculate responsive columns based on terminal width
+	// Adjust for tree column width vs default ID column width
+	adjustedWidth := termWidth - treeColWidth + ColWidthID
+	cols := CalculateResponsiveColumns(adjustedWidth, hasTags)
+
+	// Calculate title width from remaining space
+	// Account for: tree/ID col, type col, status col, priority symbol (2), space before tags (1)
+	titleWidth := termWidth - treeColWidth - ColWidthType - ColWidthStatus - 3
+	if cols.ShowTags {
+		titleWidth -= cols.Tags
+	}
+	if titleWidth < 20 {
+		titleWidth = 20
+	}
+
 	// Header with manual padding (lipgloss Width doesn't handle styled strings well)
 	headerCol := lipgloss.NewStyle().Foreground(ColorMuted)
 	idHeader := headerCol.Render("ID") + strings.Repeat(" ", treeColWidth-2)
-	typeHeader := headerCol.Render("TYPE") + strings.Repeat(" ", 12-4)
-	statusHeader := headerCol.Render("STATUS") + strings.Repeat(" ", 14-6)
+	typeHeader := headerCol.Render("TYPE") + strings.Repeat(" ", ColWidthType-4)
+	statusHeader := headerCol.Render("STATUS") + strings.Repeat(" ", ColWidthStatus-6)
 
 	header := idHeader + typeHeader + statusHeader + headerCol.Render("TITLE")
-	dividerWidth := treeColWidth + 12 + 14 + 50
+	if cols.ShowTags && titleWidth > 5 {
+		header += strings.Repeat(" ", titleWidth-5+3) + headerCol.Render("TAGS") // +3 for priority/spacing
+	}
+	dividerWidth := termWidth - 1 // -1 to avoid wrapping on exact terminal width
 	sb.WriteString(header)
 	sb.WriteString("\n")
 	sb.WriteString(Muted.Render(strings.Repeat("─", dividerWidth)))
 	sb.WriteString("\n")
 
+	// Build render config from responsive columns
+	renderCfg := treeRenderConfig{
+		treeColWidth: treeColWidth,
+		titleWidth:   titleWidth,
+		cols:         cols,
+	}
+
 	// Render nodes (depth 0 = root level, no ancestry yet)
-	renderNodes(&sb, nodes, 0, nil, cfg, treeColWidth, hasTags)
+	renderNodes(&sb, nodes, 0, nil, cfg, renderCfg)
 
 	return sb.String()
 }
 
+// treeRenderConfig holds computed rendering configuration for tree output
+type treeRenderConfig struct {
+	treeColWidth int
+	titleWidth   int
+	cols         ResponsiveColumns
+}
+
 // renderNodes recursively renders tree nodes with proper indentation.
 // depth 0 = root level (no connector), depth 1+ = nested (has connector)
 // ancestry tracks whether each parent level was a last child (true = last, no continuation line needed)
-func renderNodes(sb *strings.Builder, nodes []*TreeNode, depth int, ancestry []bool, cfg *config.Config, treeColWidth int, hasTags bool) {
+func renderNodes(sb *strings.Builder, nodes []*TreeNode, depth int, ancestry []bool, cfg *config.Config, renderCfg treeRenderConfig) {
 	for i, node := range nodes {
 		isLast := i == len(nodes)-1
-		renderNode(sb, node, depth, isLast, ancestry, cfg, treeColWidth, hasTags)
+		renderNode(sb, node, depth, isLast, ancestry, cfg, renderCfg)
 		// Only add to ancestry when depth > 0 (roots have no connectors to continue)
 		if len(node.Children) > 0 {
 			var newAncestry []bool
 			if depth > 0 {
 				newAncestry = append(ancestry, isLast)
 			}
-			renderNodes(sb, node.Children, depth+1, newAncestry, cfg, treeColWidth, hasTags)
+			renderNodes(sb, node.Children, depth+1, newAncestry, cfg, renderCfg)
 		}
 	}
 }
 
 // renderNode renders a single tree node with tree connectors.
-// treeColWidth is the fixed width of the ID column (includes space for tree connectors).
 // depth 0 = root (no connector), depth 1+ = nested (has connector)
 // ancestry tracks whether each parent level was a last child (true = last, no continuation line needed)
-func renderNode(sb *strings.Builder, node *TreeNode, depth int, isLast bool, ancestry []bool, cfg *config.Config, treeColWidth int, hasTags bool) {
+func renderNode(sb *strings.Builder, node *TreeNode, depth int, isLast bool, ancestry []bool, cfg *config.Config, renderCfg treeRenderConfig) {
 	b := node.Bean
 
 	// Build tree prefix from ancestry
@@ -248,21 +280,22 @@ func renderNode(sb *strings.Builder, node *TreeNode, depth int, isLast bool, anc
 	// Get colors from config
 	colors := cfg.GetBeanColors(b.Status, b.Type, b.Priority)
 
-	// Use shared RenderBeanRow function
+	// Use shared RenderBeanRow function with responsive columns
 	row := RenderBeanRow(b.ID, b.Status, b.Type, b.Title, BeanRowConfig{
 		StatusColor:   colors.StatusColor,
 		TypeColor:     colors.TypeColor,
 		PriorityColor: colors.PriorityColor,
 		Priority:      b.Priority,
 		IsArchive:     colors.IsArchive,
-		MaxTitleWidth: 50,
+		MaxTitleWidth: renderCfg.titleWidth,
 		ShowCursor:    false,
 		Tags:          b.Tags,
-		ShowTags:      hasTags,
-		MaxTags:       1,
+		ShowTags:      renderCfg.cols.ShowTags,
+		TagsColWidth:  renderCfg.cols.Tags,
+		MaxTags:       renderCfg.cols.MaxTags,
 		TreePrefix:    prefix,
 		Dimmed:        !node.Matched,
-		IDColWidth:    treeColWidth,
+		IDColWidth:    renderCfg.treeColWidth,
 	})
 
 	sb.WriteString(row)
