|
1 | 1 | import logging |
2 | 2 |
|
3 | 3 |
|
4 | | -def get_logger(name, log_level="info", fmt=None): |
5 | | - """Return a logger instance. |
| 4 | +class _DefaultStderrHandler(logging.Handler): |
| 5 | + """Emit WARNING+ when the application has not configured logging. |
6 | 6 |
|
7 | | - No handler is attached. A ``NullHandler`` counts as a handler and stops |
8 | | - Python from sending WARNING and above to ``logging.lastResort`` (stderr) |
9 | | - when the application has not configured logging. |
| 7 | + ``NullHandler`` counts as a handler and prevents ``logging.lastResort`` |
| 8 | + from running, which hid RedisVL warnings before #786. This handler forwards |
| 9 | + WARNING and above to stderr (via ``lastResort``) when the root logger has |
| 10 | + no handlers, and forwards to the root logger once logging is configured. |
| 11 | + Exception tracebacks are not written here so CLI code can log with |
| 12 | + ``exc_info`` for configured apps without duplicating tracebacks on stderr. |
10 | 13 | """ |
11 | 14 |
|
| 15 | + def __init__(self) -> None: |
| 16 | + super().__init__(level=logging.WARNING) |
| 17 | + |
| 18 | + def emit(self, record: logging.LogRecord) -> None: |
| 19 | + root = logging.getLogger() |
| 20 | + if root.handlers: |
| 21 | + root.handle(record) |
| 22 | + return |
| 23 | + clean = logging.makeLogRecord( |
| 24 | + { |
| 25 | + **record.__dict__, |
| 26 | + "exc_info": None, |
| 27 | + "exc_text": None, |
| 28 | + "stack_info": None, |
| 29 | + } |
| 30 | + ) |
| 31 | + logging.lastResort.handle(clean) |
| 32 | + |
| 33 | + |
| 34 | +def get_logger(name, log_level="info", fmt=None): |
| 35 | + """Return a logger instance.""" |
| 36 | + |
12 | 37 | # Use file name if logger is in debug mode |
13 | 38 | name = "RedisVL" if log_level == "debug" else name |
14 | 39 |
|
15 | | - return logging.getLogger(name) |
| 40 | + logger = logging.getLogger(name) |
| 41 | + if not any(isinstance(h, _DefaultStderrHandler) for h in logger.handlers): |
| 42 | + logger.addHandler(_DefaultStderrHandler()) |
| 43 | + logger.propagate = False |
| 44 | + return logger |
0 commit comments