Repository navigation
fix changeset dependency publishing - #3145
Merged
Merged
Conversation
vadim-korolik
force-pushed
the
vadim/fix-publish
branch
from
October 6, 2022 18:56
6c1190a to
15b664a
Compare
ccschmitz
reviewed
Oct 6, 2022
| "scripts": { | ||
| "build": "tsc && rollup -c", | ||
| "build": "yarn types && rollup -c", | ||
| "types": "tsc", |
aptlin
reviewed
Oct 6, 2022
mayberryzane
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
highlight.run package issue reported in intercom
workspace:*syntax does not bundle dependencies but instead expects the dependent package to be published.For example,
highlight.runwould be depending on@highlight-run/client, but that package is not published.changesets/changesets#432
Instead, use bundledDependencies to have yarn package dependencies into each package.
How did you test this change?
yarn build:alllocally andyalc publishto try thehighlight.runpackage locally.before, i would receive an error running
yarn. no longer seeing the error.Are there any deployment considerations?
Will test published npm package.