fixed issue with license check and skipExistingHeaders #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if skipExistingHeaders is true
|
Jeroen van Erp » license-gradle-plugin #15 SUCCESS |
|
Completely agree. In case the project owner does not, I'll submit that change as a separate pull request. |
hierynomus
added a commit
that referenced
this pull request
Feb 6, 2014
fixed issue with license check and skipExistingHeaders
|
Thanx! Merged it. |
jfarrell
added a commit
to apache/aurora
that referenced
this pull request
Jun 26, 2014
…d debug output Upgrades license plugin to latest version which contains updates to silence ignored headers [1]. [1]: hierynomus/license-gradle-plugin#31 Testing Done: ./gradlew -Pq clean build Bugs closed: AURORA-231 Reviewed at https://reviews.apache.org/r/22956/
kevinburg
pushed a commit
to foursquare/incubator-aurora
that referenced
this pull request
Jul 1, 2014
…d debug output Upgrades license plugin to latest version which contains updates to silence ignored headers [1]. [1]: hierynomus/license-gradle-plugin#31 Testing Done: ./gradlew -Pq clean build Bugs closed: AURORA-231 Reviewed at https://reviews.apache.org/r/22956/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If skipExistingHeaders is true, license check does not distinguish between files with a different header and files with no headers. The correct behavior should be files with a different header are ignored and files with no header are reported. This pull request adds a test which exposes the issue and adds a fix.