Add Discord webhook support to monitor#147
Merged
hidai25 merged 1 commit intohidai25:mainfrom Apr 1, 2026
Merged
Conversation
Owner
|
Nicely done @zeel2104 ! The implementation mirrors the Slack notifier cleanly — webhook Two tiny style nits for a follow-up (not blocking):
Merging — thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Discord webhook support to
evalview monitor, matching the existing Slack alert flow for regressions, recoveries, and performance spikes.Related Issue
Fixes #80
Type of Change
Changes Made
DiscordNotifierinevalview/core/discord_notifier.pywithsend_regression_alert(),send_recovery_alert(), and performance alert support.--discord-webhooksupport toevalview monitorwith the same priority chain as Slack: CLI flag > config > env var.monitor.discord_webhookand environment variable fallback viaEVALVIEW_DISCORD_WEBHOOK.Testing
Ran the focused monitor/config test suite after setting writable local temp directories for pytest on Windows.
Test Configuration
Tests Added/Modified
Manual Testing Steps
--discord-webhook,monitor.discord_webhook, orEVALVIEW_DISCORD_WEBHOOK.evalview monitoragainst a test suite with baselines.Checklist
Code Quality
blackto format my coderuffand fixed any linting issuesmypyand fixed any type errorsDocumentation
Testing
Dependencies
pyproject.tomlBreaking Changes
None.
Screenshots (if applicable)
N/A
Additional Notes
This change reuses the existing monitor alert structure so Discord support behaves consistently with Slack while using Discord's webhook payload format (
content).Reviewer Notes
Please pay special attention to:
By submitting this pull request, I confirm that: