Step 18: 카프카 메시지 발행 적용 및 Transactional Outbox Pattern 적용#40
Merged
kilhyeonjun merged 5 commits intomasterfrom Nov 26, 2024
Merged
Step 18: 카프카 메시지 발행 적용 및 Transactional Outbox Pattern 적용#40kilhyeonjun merged 5 commits intomasterfrom
kilhyeonjun merged 5 commits intomasterfrom
Conversation
kilhyeonjun
commented
Nov 21, 2024
| private final DataPlatformSendService sendService; | ||
|
|
||
| @KafkaListener(topics = EventType.PAYMENT_SUCCESS, groupId = "payment-group") | ||
| public void consume(Long paymentId) { |
Contributor
Author
There was a problem hiding this comment.
수신 기록 Table을 두어 consume시 eventId를 같이 전달 받으면서 수신 기록 Table에 유니크 한 row를 추가하면서 중복 컨슘의 방지가 필요했을지 의문입니다.
Comment on lines
+15
to
+16
| @Getter | ||
| private static final List<String> messages = new ArrayList<>(); |
Contributor
Author
There was a problem hiding this comment.
테스트 검증을 위해 사용한 값인데 실제 PRD 환경에서는 사용이 되면 안될 것 같은데 이벤트 수신 로그 table을 만들어서 해당 값을 조회하는 방식으로 가야했을지 의문이네요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
작업 내용
리뷰포인트