Step 13: 쿼리 캐싱 혹은 Redis 를 이용한 로직 이관을 통해 성능 개선 보고서#31
Merged
kilhyeonjun merged 3 commits intomasterfrom Nov 7, 2024
Merged
Conversation
kilhyeonjun
commented
Nov 7, 2024
Comment on lines
+49
to
+51
| ### TODO: STEP14 - 대기열 성능 개선 | ||
|
|
||
| 대기열 성능 개선 작업은 다음 과제에서 진행할 예정입니다. No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
STEP 14에서 이어서 작성할 예정입니다.
STEP 14 요구사항
-
콘서트 예약 시나리오(대기열 인원수 제한 없음)
대기열 구현에 대한 설계를 진행하고, 설계한 내용과 부합하도록 적절하게 동작하는 대기열을 구현하여 제출
- Redis, Queue, MQ 등 DB가 아닌 다른 수단을 활용해 대기열 개선 설계 및 구현 (”Nice to have”)
Comment on lines
+33
to
+39
| @Cacheable(value = CacheName.CONCERT, key = "#param.id") | ||
| Concert getConcert(GetConcertByIdParam param); | ||
|
|
||
| @Cacheable(value = CacheName.CONCERT, key = "#param.id") | ||
| Concert getConcert(GetConcertByIdWithLockParam param); | ||
|
|
||
| @Cacheable(value = CacheName.CONCERT_SCHEDULE, key = "#param.id") |
Contributor
Author
There was a problem hiding this comment.
ConcertRepository에 @Cacheable를 사용했습니다.
캐싱을 한다는 부분을 도메인이 모르게 ConcertRepositoryImple(구현체)에 작성하여 인프라스트럭처에서 관리하는게 더 좋았을까요?
There was a problem hiding this comment.
이건 구현체에 캐시 코드를 작성하게 될 경우에, 문제가 생길 수 있습니다. 실제로 repository 쓰는 클라이언트는 작성해주신 interface 만 알고 있으니까요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
작업 내용
리뷰포인트