Switch Travis CI test configuration to pytest and add matplotlib tests#954
Merged
Conversation
jthielen
force-pushed
the
pytest-and-mpl-tests
branch
from
a29847f to
67e0c51
Compare
Contributor
Author
|
The switch to pytest seems to be working great, but the matplotlib tests are not matching the baselines I created locally. I'll be taking a look at those, and once I can figure out what is wrong with them, this should be ready for review. |
jthielen
force-pushed
the
pytest-and-mpl-tests
branch
from
ffa0319 to
f666135
Compare
Contributor
Author
|
All the tests are passing now, so this should be ready for review and merge. |
Owner
|
bors r+ |
bors Bot
added a commit
that referenced
this pull request
Dec 26, 2019
954: Switch Travis CI test configuration to pytest and add matplotlib tests r=hgrecco a=jthielen As discussed in #947, this PR switches Travis CI to use pytest for Pint's test suite instead of unittest. As a motivating example, basic tests for `pint.matplotlib` are added (which closes #897). - [x] Closes #897, towards #947 (but does not fully resolve it) - [x] Executed ``black -t py36 . && isort -rc . && flake8`` with no errors - [x] The change is fully covered by automated unit tests - ~~Documented in docs/ as appropriate~~ - [x] Added an entry to the CHANGES file Co-authored-by: Jon Thielen <[email protected]>
Owner
|
Just as a a reminder for the future. Now that pytest is available we could streamline some of the existing tests to make good use of it. |
Contributor
Build succeeded |
This was referenced Dec 26, 2019
Contributor
|
👍
ParametrizedTestCase: pytest.mark.parametrize:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #947, this PR switches Travis CI to use pytest for Pint's test suite instead of unittest. As a motivating example, basic tests for
pint.matplotlibare added (which closes #897).black -t py36 . && isort -rc . && flake8with no errorsDocumented in docs/ as appropriate