Skip to content

Pytest migration#1235

Merged
hgrecco merged 9 commits into
masterfrom
_pytest_migration
Jan 20, 2021
Merged

Pytest migration#1235
hgrecco merged 9 commits into
masterfrom
_pytest_migration

Conversation

@hgrecco
Copy link
Copy Markdown
Owner

@hgrecco hgrecco commented Jan 16, 2021

The intento of this large commit is to move away from unittest
into pytest.

To speed-up migration we made certain choices that might
need to be revisted in the future:
- use pytest-subtests to replace unittest subtest infrastructure
  A lot of this might be better using parametrize
- While we have removed certain classes and flatten them to
  functions, some were kept for no particular reason
  (rewriting the QuantityTestCase base class)
- We have created some fixtures but not optimized.
  Feature optimization (i.e. using global registries for certain
  tests might speed up testing as it will void constructing
  the registry over and over)
@hgrecco
Copy link
Copy Markdown
Owner Author

hgrecco commented Jan 17, 2021

bors r+

bors Bot added a commit that referenced this pull request Jan 17, 2021
1235: Pytest migration r=hgrecco a=hgrecco

- [x] Closes #947  (insert issue number)
- [x] Executed ``pre-commit run --all-files`` with no errors
- [x] The change is fully covered by automated unit tests
- [x] Documented in docs/ as appropriate
- [x] Added an entry to the CHANGES file


Co-authored-by: Hernan <[email protected]>
Co-authored-by: Hernan Grecco <[email protected]>
@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Jan 17, 2021

Timed out.

@hgrecco hgrecco mentioned this pull request Jan 20, 2021
5 tasks
@hgrecco hgrecco merged commit b36d0a6 into master Jan 20, 2021
@hgrecco hgrecco deleted the _pytest_migration branch January 20, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switching to pytest for unit testing framework; Use doctest more extensively

1 participant