Pytest migration#1235
Merged
Merged
Conversation
The intento of this large commit is to move away from unittest into pytest. To speed-up migration we made certain choices that might need to be revisted in the future: - use pytest-subtests to replace unittest subtest infrastructure A lot of this might be better using parametrize - While we have removed certain classes and flatten them to functions, some were kept for no particular reason (rewriting the QuantityTestCase base class) - We have created some fixtures but not optimized. Feature optimization (i.e. using global registries for certain tests might speed up testing as it will void constructing the registry over and over)
Owner
Author
|
bors r+ |
bors Bot
added a commit
that referenced
this pull request
Jan 17, 2021
1235: Pytest migration r=hgrecco a=hgrecco - [x] Closes #947 (insert issue number) - [x] Executed ``pre-commit run --all-files`` with no errors - [x] The change is fully covered by automated unit tests - [x] Documented in docs/ as appropriate - [x] Added an entry to the CHANGES file Co-authored-by: Hernan <[email protected]> Co-authored-by: Hernan Grecco <[email protected]>
Contributor
|
Timed out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-fileswith no errors