impl/workflow-history-deeplink#284
Merged
Merged
Conversation
…-linkable
The executor's execution_id now equals the persisted ExecutionHistory row id
(threaded from the API layer's per-run execution_id used for cancellation/active
tracking). This makes /workflows/{id}/{$executionId} resolve to that run for
Bring-to-Canvas, and the error-workflow run_id (str(history_entry.id)) now matches
$executionId. Fallback execution_id is a canonical UUID string.
…t mapping) Route-driven bring-to-canvas now fetches via workflowStore.fetchExecutionHistoryEntry (canonical server->entry mapping incl. highlight) and passes the full ExecutionResult as the third loadHistoryInputs arg, exactly like ExecutionHistoryDialog. Previously it passed only node_results, so executionResult had no highlight/outputs -> no Execution Highlights popup and mis-mapped output node. E2E now asserts the highlights panel.
…rea components Changed the CSS class for textarea elements to allow vertical resizing instead of being fixed in size. This enhances user experience by providing more flexibility in input areas.
Real GC collections invoke the global gc.callbacks hook these tests drive manually, recording spurious pauses and consuming the patched perf_counter budget -> intermittent KeyError: 'gc_pause_count' in CI. Disable automatic GC for the test class so only the simulated callbacks run.
Extract check.sh's file-line-limit guard into scripts/check-file-line-limits.sh and run it as an early step in the PR 'check' job, so the limit is enforced in CI (previously local-only) without logic drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{"result": {"wfName": "a", "description": "desc", "path": "/workflows/c1546303-d24e-456a-bb43-a5a0c7cee0f6", "url": "http://localhost:4017/workflows/c1546303-d24e-456a-bb43-a5a0c7cee0f6", "executionId": "90b97e43320544beb00cb511c54190ef"}}
canvas itself
http://localhost:4017/workflows/c1546303-d24e-456a-bb43-a5a0c7cee0f6
execution with historyId , (bring to canvas)
http://localhost:4017/workflows/c1546303-d24e-456a-bb43-a5a0c7cee0f6/847a2318-b56f-46b6-8e29-15e394ac6b2c