fix: clarify plugin node panel states#277
Merged
ckakgun merged 3 commits intoJul 2, 2026
Merged
Conversation
mbakgun
reviewed
Jul 1, 2026
mbakgun
left a comment
mbakgun
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this one, and for the earlier plugin PRs too. Nice follow-up work and good test coverage. 🎉🤗
Two things to fix before merge:
-
The frontend and backend now disagree on a missing
pluginNodeKey. This PR shows a "missing plugin node key" state and hides the config fields, but the backendresolve_node_functionstill falls back to the first node of the matching kind and runs it. So such a node is unconfigurable in the panel while still executing. Please align the two sides (either both fall back, or both treat it as an error). -
nodeDef's?? nodes[0]fallback is now dead code sincestatusMessageblanks the fields. Please remove it.
Once those are in, good to merge. 🚀
Collaborator
|
thank you ! :) 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/pluginsresponses for the new panel states and a valid plugin fixtureValidation
cd frontend && bun run lint:checkcd frontend && bun run typecheck./check.sh(1729 tests, 1729 passed)E2E note
frontend/e2e/plugin-node-properties.spec.ts../run_e2e.sh e2e/plugin-node-properties.spec.tswas blocked because Docker daemon is not running and Docker Desktop is not installed/found on this machine.Review
pluginNodeKeywas still falling back to the first plugin node; fixed with an explicit missing-key state and E2E case.