Skip to content

fix: make plugin dependency locking cross-platform#276

Merged
mbakgun merged 1 commit into
heymrun:mainfrom
VeraPyuyi:codex/fix-plugin-deps-lock-cross-platform
Jul 1, 2026
Merged

fix: make plugin dependency locking cross-platform#276
mbakgun merged 1 commit into
heymrun:mainfrom
VeraPyuyi:codex/fix-plugin-deps-lock-cross-platform

Conversation

@VeraPyuyi

Copy link
Copy Markdown
Contributor

Summary

  • make startup plugin dependency reinstall locking work on Windows and POSIX
  • keep ensure_dependencies_installed() best-effort by logging lock/import/install failures instead of raising
  • add regression coverage for no-op empty deps, Windows msvcrt locking, lock failures, and dependency install failures

Validation

  • cd backend && uv run pytest tests/test_plugin_store.py tests/test_plugin_loader.py tests/test_plugin_manifest.py tests/test_plugin_node.py tests/test_plugins_api.py -q (34 passed)
  • cd backend && uv run ruff check app/services/plugin_store.py tests/test_plugin_store.py
  • cd backend && uv run ruff format --check app/services/plugin_store.py tests/test_plugin_store.py
  • ./check.sh (1733 tests, 1733 passed)

Review

  • Initial code review found missing install-failure coverage; fixed and amended.
  • Final review reported no Critical, Important, or Minor findings.

@mbakgun mbakgun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much ! 🤗

@mbakgun mbakgun merged commit 01bb81e into heymrun:main Jul 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants