fix: make plugin path safety checks cross-platform#272
Merged
ckakgun merged 1 commit intoJul 1, 2026
Conversation
ckakgun
approved these changes
Jul 1, 2026
ckakgun
left a comment
ckakgun
left a comment
Collaborator
There was a problem hiding this comment.
Yes, thank you for your contribution. 🎊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Path.relative_toRoot cause
The previous containment checks compared resolved paths as strings with a hard-coded
/separator. On Windows, resolved paths use\, so valid plugin members could be reported as unsafe.Validation
python -m pytest tests/test_plugin_store.py tests/test_plugin_loader.py tests/test_plugin_manifest.py tests/test_plugin_dsl_prompt.py tests/test_plugin_node.py -qpython -m ruff check app/services/plugin_store.py app/api/plugins.py tests/test_plugin_store.pypython -m ruff format --check app/services/plugin_store.py app/api/plugins.py tests/test_plugin_store.pygit diff --checkbash ./check.shvia Git Bash: 1729 tests, 1729 passed